chore: string type also allows as args in Intl.NumberFormat.format#61628
Closed
hengistchan wants to merge 1 commit intomicrosoft:mainfrom
Closed
chore: string type also allows as args in Intl.NumberFormat.format#61628hengistchan wants to merge 1 commit intomicrosoft:mainfrom
string type also allows as args in Intl.NumberFormat.format#61628hengistchan wants to merge 1 commit intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
hengistchan
changed the title
string type also allows as args in Intl.NumberFormat.format
Renegade334
reviewed
May 3, 2025
Contributor
Renegade334
left a comment
Renegade334
left a comment
There was a problem hiding this comment.
Supporting numeric string arguments is an es2023 addition, and is already present in the libs. See #57595.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat/format#parameters
Fixes #61629